fix: pipeline import with identically-named nested dirs (fixes #74)#91
Open
Abdeltoto wants to merge 1 commit intoREGOVAR:masterfrom
Open
fix: pipeline import with identically-named nested dirs (fixes #74)#91Abdeltoto wants to merge 1 commit intoREGOVAR:masterfrom
Abdeltoto wants to merge 1 commit intoREGOVAR:masterfrom
Conversation
…R#74) When a zip contains name/name/, shutil.move would move the inner dir into the outer one instead of to root, leaving rmdir to fail. Rename the top dir to a UUID first to avoid the conflict. Also fix typo FAILLED -> FAILED in manifest validation errors. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #74
When a zip archive contains nested directories with the same name (e.g.
ame/name/), \shutil.move\ moves the inner directory into the outer one instead of to root, leaving \os.rmdir\ to fail on a non-empty directory.
Fix: Rename the top directory to a UUID before moving files, as suggested by @Arkanosis in the issue comments.
Also fixes typo FAILLED -> FAILED in manifest validation error messages.
Made with Cursor